If Israel is supposed to be our greatest ally, why have they been caught spying on us so many times?

There's a simple answer to your question: everyone spies on everyone. To think otherwise is to be ignorant of world affairs.